Skip to content

switch max attribute bytes to per tenant and also check event links a… #4633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 29, 2025

Conversation

ie-pham
Copy link
Contributor

@ie-pham ie-pham commented Jan 28, 2025

What this PR does: Enforce max attribute byte size at the event, link, and instrumentation level. Make config per tenant a well.

BREAKING CHANGE ***
renamed max_span_attr_byte => max_attribute_bytes

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]
@@ -149,6 +151,7 @@ func (l *LegacyOverrides) toNewLimits() Overrides {
MaxLocalTracesPerUser: l.MaxLocalTracesPerUser,
MaxGlobalTracesPerUser: l.MaxGlobalTracesPerUser,
TenantShardSize: l.IngestionTenantShardSize,
MaxAttributeBytes: l.IngestionMaxAttributeBytes,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have tests that lock this copying behavior down?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am adding a test to make sure the conversion between the legacy and new format is working. is that what you're looking for?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, also just kind of asking if we have these tests generally?

@ie-pham ie-pham merged commit d544ec1 into grafana:main Jan 29, 2025
14 checks passed
Copy link
Contributor

@knylander-grafana knylander-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the docs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants