-
Notifications
You must be signed in to change notification settings - Fork 585
switch max attribute bytes to per tenant and also check event links a… #4633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…nd instrumentation scopes
@@ -149,6 +151,7 @@ func (l *LegacyOverrides) toNewLimits() Overrides { | |||
MaxLocalTracesPerUser: l.MaxLocalTracesPerUser, | |||
MaxGlobalTracesPerUser: l.MaxGlobalTracesPerUser, | |||
TenantShardSize: l.IngestionTenantShardSize, | |||
MaxAttributeBytes: l.IngestionMaxAttributeBytes, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have tests that lock this copying behavior down?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i am adding a test to make sure the conversion between the legacy and new format is working. is that what you're looking for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, also just kind of asking if we have these tests generally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating the docs!
What this PR does: Enforce max attribute byte size at the event, link, and instrumentation level. Make config per tenant a well.
BREAKING CHANGE ***
renamed
max_span_attr_byte
=>max_attribute_bytes
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]