Set gRPC compression default to snappy in all cases #4696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Elliott <number101010@gmail.com>
joe-elliott
requested review from
knylander-grafana,
mdisibio,
mapno,
yvrhdn,
zalegrala,
electron0zero,
ie-pham,
stoewer and
javiermolinar
as code owners
ie-pham
approved these changes
Feb 13, 2025
joe-elliott
added
type/bug
|
This PR must be merged before a backport PR will be created. |
3 tasks
electron0zero
approved these changes
Feb 14, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Feb 14, 2025
* Re add snappy compression in gRPC Signed-off-by: Joe Elliott <number101010@gmail.com> * manifest Signed-off-by: Joe Elliott <number101010@gmail.com> * changelog Signed-off-by: Joe Elliott <number101010@gmail.com> * manifest Signed-off-by: Joe Elliott <number101010@gmail.com> * changelog Signed-off-by: Joe Elliott <number101010@gmail.com> --------- Signed-off-by: Joe Elliott <number101010@gmail.com> (cherry picked from commit c8d9180)
joe-elliott
added a commit
that referenced
this pull request
Feb 14, 2025
…4701) * Set gRPC compression default to snappy in all cases (#4696) * Re add snappy compression in gRPC Signed-off-by: Joe Elliott <number101010@gmail.com> * manifest Signed-off-by: Joe Elliott <number101010@gmail.com> * changelog Signed-off-by: Joe Elliott <number101010@gmail.com> * manifest Signed-off-by: Joe Elliott <number101010@gmail.com> * changelog Signed-off-by: Joe Elliott <number101010@gmail.com> --------- Signed-off-by: Joe Elliott <number101010@gmail.com> (cherry picked from commit c8d9180) * ci? --------- Co-authored-by: Joe Elliott <number101010@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets gRPC compression between all components to be "snappy". This feels like a balanced approach to compression between components that will work for most installs. If you prefer a different balance of CPU/Memory and bandwidth consider disabling compression or using zstd.
Some details here: #4683
Revisits the choice made here: #4429