Convert throughput SLO metrics from histogram to counter - #4748
Merged
Conversation
carles-grafana
force-pushed
the
counter_throughput
branch
from
February 26, 2025 09:09
305f70c to
15a7816
Compare
carles-grafana
marked this pull request as ready for review
February 26, 2025 14:33
carles-grafana
requested review from
electron0zero,
ie-pham,
javiermolinar,
joe-elliott,
mapno,
mdisibio,
stoewer,
yvrhdn and
zalegrala
as code owners
February 26, 2025 14:33
carles-grafana
marked this pull request as draft
February 26, 2025 14:49
carles-grafana
marked this pull request as ready for review
February 26, 2025 14:54
javiermolinar
left a comment
javiermolinar
left a comment
Contributor
There was a problem hiding this comment.
This is a breaking change, what's the reason to convert it to a counter? We are losing the ability to calculate throughput percentiles
Contributor
Author
it's expected to perform better, I have discussed this with Joe, and I don't think we or anyone else is actually using the buckets, but I'll add the changelog line |
carles-grafana
force-pushed
the
counter_throughput
branch
2 times, most recently
from
February 26, 2025 15:23
857326e to
3dd2538
Compare
Collaborator
|
I don't believe the histogram gives us any value. The goal here is just to count the bytes processed per tenant. In the case that we do need quantiles on this metric it can be calculated from logs. |
joe-elliott
approved these changes
Feb 26, 2025
carles-grafana
marked this pull request as draft
February 27, 2025 14:39
carles-grafana
marked this pull request as ready for review
February 27, 2025 14:39
For performance
carles-grafana
force-pushed
the
counter_throughput
branch
from
February 27, 2025 15:20
3dd2538 to
fc560cd
Compare
mattdurham
pushed a commit
to mattdurham/tempo
that referenced
this pull request
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For performance
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]