Add support for pprof mutex/blocking - #4979
Merged
Merged
Conversation
mattdurham
commented
Apr 9, 2025
joe-elliott
reviewed
Apr 9, 2025
mattdurham
marked this pull request as ready for review
April 11, 2025 13:06
mattdurham
requested review from
carles-grafana,
electron0zero,
ie-pham,
javiermolinar,
mapno,
mdisibio,
stoewer,
yvrhdn and
zalegrala
as code owners
April 11, 2025 13:06
mattdurham
commented
Apr 11, 2025
| printVersion := flag.Bool("version", false, "Print this builds version information") | ||
| ballastMBs := flag.Int("mem-ballast-size-mbs", 0, "Size of memory ballast to allocate in MBs.") | ||
| mutexProfileFraction := flag.Int("mutex-profile-fraction", 0, "Enable mutex profiling.") | ||
| blockProfileThreshold := flag.Int("block-profile-threshold", 0, "Enable block profiling.") |
Contributor
Author
There was a problem hiding this comment.
I should change this description.
javiermolinar
approved these changes
Apr 11, 2025
javiermolinar
left a comment
javiermolinar
left a comment
Contributor
There was a problem hiding this comment.
LGTM , the changelog is not quite right though
mattdurham
added a commit
to mattdurham/tempo
that referenced
this pull request
Jun 18, 2026
* Add support for pprof mutex/blocking * Remove environment variables * Remove no longer needed comment * Change changelog.md * Change naming * Fix changelog formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
This adds default value for blocking and mutex contention. They are very low defaults to have minimal impact on cpu. In practice alloy has been running these same defaults for years. There is no documentation, I will add that in a separate PR since it will be a larger new section on starting tempo.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]