[tempo-cli] Replace fmt.Print with logger, continue on error in rewrite-blocks
#5043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zalegrala
force-pushed
the
cliRewriteTracesLoggerContinue
branch
from
6a8573c to
ebfad3f
Compare
zalegrala
requested review from
joe-elliott,
mdisibio,
mapno,
yvrhdn,
electron0zero,
ie-pham,
stoewer,
javiermolinar and
carles-grafana
as code owners
joe-elliott
reviewed
Apr 23, 2025
joe-elliott
approved these changes
Apr 23, 2025
zalegrala
force-pushed
the
cliRewriteTracesLoggerContinue
branch
from
40b9359 to
a8a998e
Compare
zalegrala
changed the title
rewrite-blocks
Update cmd/tempo-cli/cmd-rewrite-blocks.go Co-authored-by: Joe Elliott <joe.elliott@grafana.com>
zalegrala
force-pushed
the
cliRewriteTracesLoggerContinue
branch
from
a8a998e to
5aa49ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Here we modify the output long-running command
rewrite-blocksto use a logger rather than the use offmt.Print. This should be sufficient for both local and non-local use cases.Additionally, we continue on error such that in case one block has a problem, we don't halt the entire process.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]