Protect span metrics target_info against resource attributes with empty key - #5148
Merged
Conversation
mdisibio
requested review from
carles-grafana,
electron0zero,
ie-pham,
javiermolinar,
joe-elliott,
mapno,
stoewer,
yvrhdn and
zalegrala
as code owners
May 21, 2025 12:14
mapno
approved these changes
May 21, 2025
rlankfo
approved these changes
May 21, 2025
mattdurham
pushed a commit
to mattdurham/tempo
that referenced
this pull request
Jun 18, 2026
…ty key (grafana#5148) * Protect span metrics target_info against resource attributes with empty key * changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
It is technically possible to send a resource attribute with an empty key over the wire, and these cause issues for span metrics target_info. It will lead to invalid label errors downstream in metrics datasources. This skips over them.
Note - Target info pulls in all resource attributes dynamically (minus any exclusions). So I think it is ok to skip silently here. Versus, for the regular span metrics, dimensions are configured explicitly. In that case I think the current behavior of bubbling those errors up is preferred.
Which issue(s) this PR fixes:
Fixes #5151
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]