Record block data size in meta #515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annanay25
reviewed
Feb 9, 2021
joe-elliott
reviewed
Feb 9, 2021
There was a problem hiding this comment.
An appender is used by both the compactor and complete blocks. It already does some record keeping w/r to the amount of data that has been appended. If we want to track "totalSize" does it make sense to just put the logic there?
Echo @annanay25 's question about whether or not we need both. the compressed size seems like enough to me. If we are just interested in compression ratio we may want to consider metricing it. I know Loki does that.
joe-elliott
approved these changes
Feb 9, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR adds a new field to the block meta for the final data file size, and support for this and other recent fields to the tempo-cli. This PR is a precursor to switching compaction over to a target file size instead of target trace count.
Which issue(s) this PR fixes:
n/a
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]