fix: fix identify root spans with child_of links - #5557
Conversation
|
Greetings. Do you have any doc that you need reviewed for this PR? The Documentation box is checked but I didn't see any doc files in the PR. BTW, nice changelog entry. It's very clear and concise. |
|
Sorry, checked by mistaken, no docs added. Already changed the field @knylander-grafana Thanks for the changelog! |
|
Nice! Thank you for taking this on. The example in the original issue had child of links that linked to the same trace. I'm wondering if we want to check for both child of links and if they are internal to the trace. @ie-pham do you have input on this? |
joe-elliott
left a comment
joe-elliott
left a comment
There was a problem hiding this comment.
Apologies for taking so long to get to this. Thank you for this contribution 🙏
…ue-to-instrumentations
This comment has been minimized.
This comment has been minimized.
…tified-due-to-instrumentations
ie-pham
left a comment
ie-pham
left a comment
There was a problem hiding this comment.
LGTM! Amazing job. Thank you for contributing
* feat: add support for identifying root spans with child_of links in traceToParquet * feat: add pr in changelog * Verify if link childs are internal to the trace
4 participants
What this PR does:
Fixes incorrect root span detection in Parquet trace conversion (v2, v3, v4, v5). Now, a span is only considered root if it has no parent and no child_of link
Which issue(s) this PR fixes:
Fixes #3634
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]