Add live-stores to jsonnet lib #5591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapno
commented
Aug 29, 2025
mapno
requested review from
carles-grafana,
electron0zero,
ie-pham,
javiermolinar,
joe-elliott,
mdisibio,
ruslan-mikhailov,
stoewer,
yvrhdn and
zalegrala
as code owners
joe-elliott
approved these changes
Aug 29, 2025
| compactor: {} | ||
| distributor: {} | ||
| http_api_prefix: "" | ||
| ingester: |
There was a problem hiding this comment.
do we need this block? not sure what it does
There was a problem hiding this comment.
It's inherited from the base config, it's set in all components. I thought of cleaning it up but didn't want to change too many things outside the scope of this PR
| - key: name | ||
| operator: NotIn | ||
| values: | ||
| - live-store-zone-a |
There was a problem hiding this comment.
not 100% sure what these scheduling affinity rules do, but it's ok if multiple zone-a livestores are on the same node. we need to make sure that zone-a livestores never share a node with zone-b
There was a problem hiding this comment.
Yes, that's exactly what it does. If allow_multiple_replicas_on_same_node is false, then it excludes nodes where other zones are running in.
mapno
added
backport release-v2.1
type/bug
mapno
added a commit
that referenced
this pull request
Sep 1, 2025
* Add livestores to jsonnet lib * Update tk example to run complete rhythm setup * Small fixes * Simplify antiaffinity config * chlog * compile!
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds required resources to run live-stores from the jsonnet library. Also updates the k3d example to run a full rhythm setup.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]