feat: improve truncated attributes visibility by logging them #5603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiermolinar
changed the title
javiermolinar
requested review from
carles-grafana,
electron0zero,
ie-pham,
joe-elliott,
mapno,
mdisibio,
ruslan-mikhailov,
stoewer,
yvrhdn and
zalegrala
as code owners
mapno
reviewed
Oct 10, 2025
| } | ||
|
|
||
| func logTruncatedAttributes(truncatedAttr []truncatedAttribute, message string, tenant string, l log.Logger) { | ||
| b, _ := json.Marshal(truncatedAttr) |
There was a problem hiding this comment.
Isn't this a lot of overhead in (potentially) every write for a log?
There was a problem hiding this comment.
yeah, i like this idea in theory, but i think this would destroy our distributors. we also need to consider that we may be logging sensitive information if we do this.
perhaps some kind of temporary way to turn this on per tenant paired with some rate limiting?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Currently we have a lack of visibility when big attributes (or attributes names) are trimmed due to the
max_attribute_byteslimit.This pr aims to fix that by logging the truncated attributes once per batch.
It discriminates between attribute values and attributes names. The original code includes both of them in the same bucket.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]