Improve shutdown time in the first 30 seconds - #5725
Merged
Conversation
ldufr
requested review from
carles-grafana,
electron0zero,
ie-pham,
javiermolinar,
joe-elliott,
mapno,
mattdurham,
mdisibio,
ruslan-mikhailov,
stoewer,
yvrhdn and
zalegrala
as code owners
October 10, 2025 08:32
|
|
mdisibio
approved these changes
Oct 10, 2025
mdisibio
left a comment
mdisibio
left a comment
Contributor
There was a problem hiding this comment.
This looks reasonable to me, but maybe @zalegrala would like to review also.
Trying to shutdown (SIGINT) tempo in the first 30 seconds would block until we got a stable key which currently takes 30 seconds. This unblock that.
ldufr
force-pushed
the
ldufresne/unblock-early-exit
branch
from
October 13, 2025 11:55
ced0418 to
c976a7f
Compare
mattdurham
pushed a commit
to mattdurham/tempo
that referenced
this pull request
Jun 18, 2026
* Improve shutdown time in the first 30 seconds Trying to shutdown (SIGINT) tempo in the first 30 seconds would block until we got a stable key which currently takes 30 seconds. This unblock that. * Updated changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Trying to shutdown (SIGINT) tempo in the first 30 seconds would block until we got a stable key which currently takes 30 seconds. With this change, it should be instantaneous.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]