generator: add validation for histogram buckets - #5991
Merged
carles-grafana merged 2 commits intoNov 21, 2025
Conversation
carles-grafana
force-pushed
the
generator_validation_histogram
branch
from
November 20, 2025 13:56
fc601e4 to
ac80b36
Compare
carles-grafana
marked this pull request as ready for review
November 20, 2025 13:57
carles-grafana
requested review from
electron0zero,
ie-pham,
javiermolinar,
joe-elliott,
mapno,
mattdurham,
mdisibio,
ruslan-mikhailov,
stoewer,
yvrhdn and
zalegrala
as code owners
November 20, 2025 13:57
carles-grafana
force-pushed
the
generator_validation_histogram
branch
from
November 21, 2025 09:03
ac80b36 to
be4a509
Compare
| return nil | ||
| } | ||
|
|
||
| func ValidateHistogramBuckets(buckets []float64, field string) error { |
Member
There was a problem hiding this comment.
nit: can we add a unit test for this?
Contributor
Author
There was a problem hiding this comment.
aren't the tests in cmd/tempo/app/overrides_validation_test.go enough?
Member
There was a problem hiding this comment.
yeah, just a nit. extra test would make it easy to refactor in future.
electron0zero
approved these changes
Nov 21, 2025
mattdurham
pushed a commit
to mattdurham/tempo
that referenced
this pull request
Jun 18, 2026
* generator: add validation for histogram buckets * Add changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]