Fix leading zero handling in native histograms implementations - #6033
Merged
zalegrala merged 3 commits intoJan 14, 2026
Conversation
zalegrala
changed the title
zalegrala
marked this pull request as ready for review
December 5, 2025 16:37
zalegrala
requested review from
carles-grafana,
electron0zero,
ie-pham,
javiermolinar,
joe-elliott,
mapno,
mattdurham,
mdisibio,
oleg-kozlyuk-grafana,
ruslan-mikhailov,
stoewer and
yvrhdn
as code owners
December 5, 2025 16:37
zalegrala
force-pushed
the
nativeHistogramLeadingZeroNewSeries
branch
2 times, most recently
from
January 9, 2026 15:24
b4156ad to
4d4a9ac
Compare
zalegrala
force-pushed
the
nativeHistogramLeadingZeroNewSeries
branch
from
January 13, 2026 14:41
4d4a9ac to
01934af
Compare
mattdurham
pushed a commit
to mattdurham/tempo
that referenced
this pull request
Jun 18, 2026
…na#6033) * Ensure leading zero handling on "both" histograms implementaions * Add test to cover native and "both" modes in native implementation * Update changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Here we ensure that the native histogram impelemtation apples the leading zero logic to both the classic (when using "both") and native implementations. This is to avoid an issue when new series are created with a null value, the transition from null -> x does not account for the first value written. In environments in which metrics are created and then age out, this can cause instability in the results.
Which issue(s) this PR fixes:
Related #2068
Related #4140
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]