Support span:childCount intrinsic with new column in vp5 - #6126
Merged
Conversation
mdisibio
marked this pull request as ready for review
January 6, 2026 00:23
mdisibio
requested review from
carles-grafana,
electron0zero,
ie-pham,
javiermolinar,
joe-elliott,
knylander-grafana,
mapno,
mattdurham,
oleg-kozlyuk-grafana,
ruslan-mikhailov,
stoewer,
yvrhdn and
zalegrala
as code owners
January 6, 2026 00:23
oleg-kozlyuk-grafana
approved these changes
Jan 6, 2026
Contributor
|
This looks comprehensive and well-rounded, LGTM |
Closed
3 tasks
mattdurham
pushed a commit
to mattdurham/tempo
that referenced
this pull request
Jun 18, 2026
* Support span:childCount intrinsic with new column in vp5 * Fix tests, update build image and re-gen traceql * changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds support for the
span:childCountintrinsic, backed by a new column in vParquet5 (still in development). This is the number of direct children on a span. It works for search, metrics, autocomplete, and drilldown/compare.Removed the unscoped
childCountvariant from the parser. This should be fine as it always returned anunsupportederror so there is no impact to existing queries.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]