Fix query-frontend conversion of dedicated column blob option - #6377
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
stoewer
marked this pull request as ready for review
February 4, 2026 11:36
stoewer
requested review from
carles-grafana,
electron0zero,
ie-pham,
javiermolinar,
joe-elliott,
mapno,
mattdurham,
mdisibio,
oleg-kozlyuk-grafana,
ruslan-mikhailov,
yvrhdn and
zalegrala
as code owners
February 4, 2026 11:36
javiermolinar
approved these changes
Feb 4, 2026
javiermolinar
left a comment
javiermolinar
left a comment
Contributor
There was a problem hiding this comment.
LGTM
We will need to create a new release 2.10.1 or 2.11 to include this fix
stoewer
added a commit
to stoewer/tempo
that referenced
this pull request
Feb 4, 2026
…on (grafana#6377) * Convert blob option correctly to and from tempopb * Add CHANGELOG.md entry for blob option fix
3 tasks
mdisibio
pushed a commit
to mdisibio/tempo
that referenced
this pull request
Feb 5, 2026
…a#6377) * Convert blob option correctly to and from tempopb * Add CHANGELOG.md entry for blob option fix
3 tasks
mdisibio
added a commit
that referenced
this pull request
Feb 5, 2026
knylander-grafana
pushed a commit
to knylander-grafana/tempo-doc-work
that referenced
this pull request
Feb 6, 2026
…a#6377) * Convert blob option correctly to and from tempopb * Add CHANGELOG.md entry for blob option fix
mattdurham
pushed a commit
to mattdurham/tempo
that referenced
this pull request
Jun 18, 2026
…a#6377) * Convert blob option correctly to and from tempopb * Add CHANGELOG.md entry for blob option fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
The
bloboption for dedicated columns was missing from the protobuf definition and conversion functions were missing support for it. This caused the query-frontend to fail when processing blocks withbloboption configured. I therefore addedBLOBtoDedicatedColumn_Optionand implemented bidirectional conversion betweenDedicatedColumnOptionBlobandtempopb.DedicatedColumn_BLOB.Used local docker compose examples to reproduce the bug and to confirm that it's solved with this change.
Which issue(s) this PR fixes:
Fixes #6370
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]