fix: normalize allowlist headers when building the allowlist map - #6481
Merged
Conversation
javiermolinar
requested review from
carles-grafana,
electron0zero,
ie-pham,
mapno,
mattdurham,
mdisibio,
oleg-kozlyuk-grafana,
ruslan-mikhailov,
stoewer,
yvrhdn and
zalegrala
as code owners
February 17, 2026 10:14
electron0zero
approved these changes
Feb 17, 2026
electron0zero
left a comment
electron0zero
left a comment
Member
There was a problem hiding this comment.
few nits, and can use one more test case. rest lgtm.
electron0zero
approved these changes
Feb 17, 2026
mattdurham
pushed a commit
to mattdurham/tempo
that referenced
this pull request
Jun 18, 2026
…fana#6481) * fix: normalize allowlist headers when building the allowlist map * add more tests and changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
The async_strip_headers_middleware was case-sensitive. Meaning that an allowlist value like x-plugin-id can fail against X-Plugin-Id.
In this PR we first normalize the headers using http.CanonicalHeaderKey when the allowlist is build and normalize again when matching them against the list.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]