enhancement: disable ingesters and simplify querier code - #6496
Conversation
![chatgpt-codex-connector[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ec51d71035
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6ffe91f6e7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| t.cfg.Distributor.IngesterWritePathEnabled = false | ||
| t.cfg.Distributor.KafkaWritePathEnabled = t.cfg.Ingest.Enabled // TODO: Don't mix config params |
There was a problem hiding this comment.
initDistributor now unconditionally disables IngesterWritePathEnabled and only enables Kafka writes when ingest.enabled is true; when ingest.enabled is false, both ingestion paths are off but PushTraces still returns success without persisting data. This creates silent data loss for any distributor process started with ingest disabled (including default-style configs), so startup should fail (or one write path should remain enabled) instead of acknowledging dropped spans.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
I'll clean up the config later on
* enhancement: disable ingesters and simplify querier code * remove leftovers * add deprecation response for spanmetricssummary
2 participants
What this PR does:
This PR removes the ingester code from the modules.go and simplify all the logic in the queriers to use only the live stores. All the references in variable names, methods, logs and traces have been renamed from ingester to live-store
BREAKING CHANGES
The secondary ingester ring is removed. We have never used this set up. If we ever need it in the future we will need to do it for the live stores.
SpanMetricsSummary is removed
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]