prevent active-series underflow in local series limiter - #6568
Merged
Conversation
Contributor
|
Do we need a changelog entry for this? |
carles-grafana
force-pushed
the
underflow
branch
from
February 27, 2026 11:17
b16e77a to
19c9e4a
Compare
carles-grafana
marked this pull request as ready for review
February 27, 2026 11:19
carles-grafana
requested review from
electron0zero,
ie-pham,
javiermolinar,
mapno,
mattdurham,
mdisibio,
oleg-kozlyuk-grafana,
ruslan-mikhailov,
stoewer,
yvrhdn and
zalegrala
as code owners
February 27, 2026 11:19
oleg-kozlyuk-grafana
approved these changes
Feb 27, 2026
`tempo_metrics_generator_registry_active_series` could wrap due to uint32 underflow when stale cleanup deletes overflow series that were never counted as active. - ignore `OnDelete` for overflow entity hash - clamp delete count to current active-series value before subtracting - add regression test for accepted+overflow stale-delete sequence
carles-grafana
force-pushed
the
underflow
branch
from
March 2, 2026 09:50
24dd689 to
df23dcf
Compare
mattdurham
pushed a commit
to mattdurham/tempo
that referenced
this pull request
Jun 18, 2026
* prevent active-series underflow in local series limiter `tempo_metrics_generator_registry_active_series` could wrap due to uint32 underflow when stale cleanup deletes overflow series that were never counted as active. - ignore `OnDelete` for overflow entity hash - clamp delete count to current active-series value before subtracting - add regression test for accepted+overflow stale-delete sequence * changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tempo_metrics_generator_registry_active_seriescould wrap due to uint32 underflowwhen stale cleanup deletes overflow series that were never counted as active.
OnDeletefor overflow entity hashWhat this PR does:
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]