export MathExpression type - #7377
Merged
Merged
Conversation
ie-pham
requested review from
carles-grafana,
electron0zero,
javiermolinar,
mapno,
mattdurham,
mdisibio,
oleg-kozlyuk-grafana,
ruslan-mikhailov,
stoewer,
yvrhdn,
zalegrala and
zhxiaogg
as code owners
June 3, 2026 22:03
Contributor
There was a problem hiding this comment.
Pull request overview
This PR exports the metrics math expression AST node in pkg/traceql so it can be referenced as a public type, and updates internal callers accordingly.
Changes:
- Rename
mathExpressiontoMathExpressionand exportRewriteKeys. - Update AST rewriting call sites to use
RewriteKeys. - Add
(*RootExpr).Expression()accessor returning*MathExpression.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/traceql/lenient_parser.go | Updates key-rewrite call to the exported RewriteKeys method. |
| pkg/traceql/ast.go | Switches RootExpr.expression to *MathExpression and adds an exported Expression() accessor. |
| pkg/traceql/ast_rewriter.go | Updates expression key rewrite call to RewriteKeys. |
| pkg/traceql/ast_metrics_math.go | Exports MathExpression type and RewriteKeys method; updates internal references accordingly. |
ruslan-mikhailov
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Checklist
.chloggen/(runmake chlog-new, ormake chlog-new FILENAME=<name>to override the default branch-name file; see.chloggen/README.md)