renames CLI flag from --storage.trace.maintenance-cycle to --storage.trace.blocklist_poll - #897
Conversation
|
We will hold off on merging this until we cut 1.1 (next week), but thanks for the fix! One nit: can we list this as a breaking change in the change log? |
7f320ca to
3cd1273
Compare
|
Thanks a lot @joe-elliott for the review and yes I fixed it to breaking change in the change log, thank you so much 😊 |
annanay25
left a comment
annanay25
left a comment
There was a problem hiding this comment.
1.1 has been cut, can you please rebase your PR over main @mritunjaysharma394? Thanks for the contribution!
3cd1273 to
9a0863a
Compare
Hi @annanay25 , thanks for the review, I have tried to do it, let me know if it works, thank you so much :) |
…trace.blocklist_poll Signed-off-by: Mritunjay Sharma <mritunjaysharma394@gmail.com>
9a0863a to
02e0c00
Compare
|
Thank you! I will merge as soon as CI passes. |
Thank you so much for all the help! Looking forward to learn and contribute more 😄 |
…trace.blocklist_poll (grafana#897) Signed-off-by: Mritunjay Sharma <mritunjaysharma394@gmail.com>
3 participants
Signed-off-by: Mritunjay Sharma mritunjaysharma394@gmail.com
What this PR does:
This PR renames
--storage.trace.maintenance-cycleto--storage.trace.blocklist_pollWhich issue(s) this PR fixes:
Fixes #862
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]