Update config defaults - #913
Merged
Merged
Conversation
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
joe-elliott
requested review from
achatterjee-grafana,
annanay25,
dgzlopes,
mapno,
mdisibio and
yvrhdn
as code owners
August 25, 2021 17:10
annanay25
approved these changes
Aug 30, 2021
annanay25
left a comment
annanay25
left a comment
Contributor
There was a problem hiding this comment.
PR needs rebase, but lgtm! Config default updates were long overdue.
mattdurham
pushed a commit
to mattdurham/tempo
that referenced
this pull request
Jun 18, 2026
* Updated defaults Signed-off-by: Joe Elliott <number101010@gmail.com> * updated manifest Signed-off-by: Joe Elliott <number101010@gmail.com> * Updated docs Signed-off-by: Joe Elliott <number101010@gmail.com> * changelog Signed-off-by: Joe Elliott <number101010@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Updates config defaults to better match what we run internally. This is not a complete mapping of our internal settings, but I think better sets up Tempo operators to succeed as they grow their clusters.
This PR also marks wal compression as no longer experimental.
Do not merge until 1.1 is cut.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]