Chore: update e2e tests workflow #303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinwcyu
force-pushed
the
kevinwcyu/update-e2e-workflow
branch
from
853fce3 to
2127406
Compare
idastambuk
approved these changes
Jan 23, 2025
|
We can test this on this PR: #302 where e2e tests are failing 🤞🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just updating the e2e tests workflow to more closely match what we have in our other repos. It's based on the workflow described in the developer docs here https://grafana.com/developers/plugin-tools/e2e-test-a-plugin/ci. I removed the
healthcheckin the docker compose file in favour of using thegrafana/plugin-actions/wait-for-grafana@mainaction. This updated workflow also runs daily so it's constantly run against the latest changes in main grafana.The main motivation for updating the workflow is that our dependabot PRs always fail on the e2e tests until a random change in the workflow file is made, e.g. d6cc0fe. This updated workflow is used in our other repos, which haven't had this issue so I'm hoping this change will fix this issue.