Auto convert w3c trace format (#184) #332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
vineethawal
changed the title
vineethawal
force-pushed
the
feature/w3c-trace-id-support
branch
from
d9786f6 to
a3359b5
Compare
vineethawal
commented
Mar 26, 2025
| @@ -414,7 +414,7 @@ func TestDatasource(t *testing.T) { | |||
| }) | |||
|
|
|||
| t.Run("getTrace query with different region", func(t *testing.T) { | |||
| response, err := queryDatasource(ds, datasource.QueryGetTrace, datasource.GetTraceQueryData{Query: "traceID", Region: "us-east-1"}) | |||
| response, err := queryDatasource(ds, datasource.QueryGetTrace, datasource.GetTraceQueryData{Query: "trace1", Region: "us-east-1"}) | |||
There was a problem hiding this comment.
Had to fix this test as I had to remove hardcoded traceId in line 185
vineethawal
commented
Mar 26, 2025
| @@ -398,7 +398,7 @@ func TestDatasource(t *testing.T) { | |||
| }) | |||
|
|
|||
| t.Run("getTrace query", func(t *testing.T) { | |||
| response, err := queryDatasource(ds, datasource.QueryGetTrace, datasource.GetTraceQueryData{Query: "traceID"}) | |||
| response, err := queryDatasource(ds, datasource.QueryGetTrace, datasource.GetTraceQueryData{Query: "trace1"}) | |||
There was a problem hiding this comment.
Had to fix this test as I had to remove hardcoded traceId in line 185
vineethawal
changed the title
vineethawal
commented
Mar 26, 2025
| func convertW3CToXRayTraceID(w3cTraceID string) string { | ||
| // X-Ray format: 1-{8 chars}-{24 chars} | ||
| if len(w3cTraceID) == 32 { | ||
| return fmt.Sprintf("1-%s-%s", w3cTraceID[0:8], w3cTraceID[8:]) |
There was a problem hiding this comment.
kevinwcyu
approved these changes
Mar 27, 2025
|
@kevinwcyu Do we have any plans for next release of this plugin? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for automatically converting W3C Trace Context format to AWS X-Ray format. This mimics the transformation behavior available in the AWS X-Ray console and allows the plugin to interoperate more effectively with systems using the standardized W3C trace context specification.
Resolves: #184