Skip to content

Implement listServiceOperations #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2025
Merged

Implement listServiceOperations #349

merged 2 commits into from
May 8, 2025

Conversation

iwysiu
Copy link
Contributor

@iwysiu iwysiu commented May 6, 2025

Implement a services resource handler and the listServiceOperations query type

Fixes #328

@iwysiu iwysiu force-pushed the iwysiu/328 branch 2 times, most recently from 88e2c63 to abc57b0 Compare May 6, 2025 19:34
@iwysiu iwysiu marked this pull request as ready for review May 6, 2025 19:57
@iwysiu iwysiu requested a review from a team as a code owner May 6, 2025 19:57
@iwysiu iwysiu requested review from idastambuk and kevinwcyu May 6, 2025 19:57
Copy link
Contributor

@kevinwcyu kevinwcyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this supposed to be working for any of the provisioned data sources yet? i'm getting a permissions error right now, just wondering if there's some other setup required for it.

@iwysiu
Copy link
Contributor Author

iwysiu commented May 7, 2025

@kevinwcyu , I forgot to mention it, its set up against us-east-1 in external dev, so if you have a key in the x-ray_dev group (with additional app signals permissions) it should work

Co-authored-by: Kevin Yu <kevinwcyu@users.noreply.github.com>
@iwysiu iwysiu merged commit 116443e into main May 8, 2025
2 checks passed
@iwysiu iwysiu deleted the iwysiu/328 branch May 8, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants