fix: typescript tasks canceled status #2684
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add cancellation checks in success/failure callbacks to prevent sending COMPLETED/FAILED events when a task is cancelled. This ensures cancelled tasks are properly marked as CANCELLED and not retried.
|
@aashmanVerma is attempting to deploy a commit to the Hatchet Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cancellation checks in success/failure callbacks to prevent sending COMPLETED/FAILED events when a task is cancelled. This ensures cancelled tasks are properly marked as CANCELLED and not retried.
Description
When a TypeScript task is cancelled, the worker was incorrectly sending status updates (COMPLETED or FAILED) to the Hatchet engine. This caused cancelled tasks to be marked as either succeeded or failed (with retries), instead of being properly marked as CANCELLED.
The fix adds cancellation checks in both the
success()andfailure()callbacks before sending status events. When a task is cancelled, the worker now suppresses status updates, allowing the engine to properly handle the CANCELLED state. This matches the Python SDK behavior.Fixes #2655
Type of change
What's Changed
success()callback to suppress COMPLETED events when task is cancelledfailure()callback to suppress FAILED events when task is cancelled