perf: skip tag render when there is no swigTags #5650
Merged
+8
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to testgit clone -b perf/tag https://github.com/D-Sketon/hexo.git
cd hexo
npm install
npm test |
Pull Request Test Coverage Report for Build 14575855222Details
💛 - Coveralls |
SukkaW
requested changes
Apr 5, 2025
yoshinorin
reviewed
Apr 21, 2025
lib/hexo/post.ts
Outdated
|
|
||
| // Return content after replace the placeholders | ||
| if (disableNunjucks) return data.content; | ||
| if (disableNunjucks || !hasTag) return data.content; |
Member
There was a problem hiding this comment.
The conditional operator here is a bit hard to follow, but since I can't think of a better solution, I think this is fine as it is.
stevenjoezhang
approved these changes
Apr 21, 2025
yoshinorin
approved these changes
Apr 22, 2025
SukkaW
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can we skip
tag.renderif there are no swig Tags?