Skip to content

Conversation

@D-Sketon
Copy link
Member

What does it do?

The previous condition ((char !== '%' && next_char === '}') || (char === '%' && next_char !== '}')) (#5618) was too restrictive and incorrectly identified valid tags containing '%' characters (like {% include 11% 22 %}) as invalid format.

This change removes the problematic validation and relies on proper tag ending detection (%}) and the existing backtracking mechanism for handling truly malformed tags.

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.
@github-actions
Copy link

How to test

git clone -b fix/8.0.0-1 https://github.com/D-Sketon/hexo.git
cd hexo
npm install
npm test
@coveralls
Copy link

coveralls commented Sep 21, 2025

Pull Request Test Coverage Report for Build 18785924685

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.526%

Totals Coverage Status
Change from base Build 18785809217: 0.0%
Covered Lines: 9871
Relevant Lines: 9918

💛 - Coveralls
@D-Sketon D-Sketon requested a review from a team September 21, 2025 13:57
wangjiezhe added a commit to wangjiezhe/wangjiezhe.github.io that referenced this pull request Sep 30, 2025
@D-Sketon D-Sketon mentioned this pull request Oct 3, 2025
2 tasks
@D-Sketon D-Sketon merged commit 0b07ee8 into hexojs:master Oct 24, 2025
22 of 23 checks passed
@D-Sketon D-Sketon deleted the fix/8.0.0-1 branch October 24, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants