Skip to content

Conversation

@D-Sketon
Copy link
Member

@D-Sketon D-Sketon commented Oct 1, 2025

What does it do?

I forgot to load the binary relation index after loadDatabase during the watch phase. This caused categories and tags to be empty when running hexo s for preview with an existing db.json.

fix https://github.com/orgs/hexojs/discussions/5692

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.
@github-actions
Copy link

github-actions bot commented Oct 1, 2025

How to test

git clone -b fix/8.0.0-5 https://github.com/D-Sketon/hexo.git
cd hexo
npm install
npm test
@coveralls
Copy link

coveralls commented Oct 1, 2025

Pull Request Test Coverage Report for Build 18314897693

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.526%

Totals Coverage Status
Change from base Build 18259215002: 0.0%
Covered Lines: 9867
Relevant Lines: 9914

💛 - Coveralls
@D-Sketon D-Sketon requested a review from a team October 1, 2025 03:38
@jerryc127
Copy link

原来这是 bug 啊。。

Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@D-Sketon D-Sketon merged commit 1accdc6 into hexojs:master Oct 16, 2025
40 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants