bump idiomorph version to 0.7.4

[htcarr3]

Should fix #1393 as well as some other idiomorph bugs.

https://github.com/bigskysoftware/idiomorph/releases/tag/v0.7.4

bigskysoftware/idiomorph@v0.7.2...v0.7.4

[dvadell]

Hello everybody,

+1 for this please. We are seeing an exception when using turbo because of idiomorph's version. In this function from idiomorph 0.7.2:

function moveBeforeById(parentNode, id, after, ctx) {
      const target =
        /** @type {Element} - will always be found */
        (
          ctx.target.querySelector(#${id}) ||
            ctx.pantry.querySelector(#${id})
        );
      removeElementFromAncestorsIdMaps(target, ctx);
      moveBefore(parentNode, target, after);
      return target;
    }

Our id has square brackets, and querySelector needs the id escaped ( with backslashes or with CSS.escape() ).

In idiomorph's 0.7.4, they changed it to handle ids fine:

function moveBeforeById(parentNode, id, after, ctx) {
      const target =
        /** @type {Element} - will always be found */
        (     
          // ctx.target.id unsafe because of form input shadowing
          // ctx.target could be a document fragment which doesn't have getAttribute
          (ctx.target.getAttribute?.("id") === id && ctx.target) ||
            ctx.target.querySelector([id="${id}"]) ||
            ctx.pantry.querySelector([id="${id}"])
        );
      removeElementFromAncestorsIdMaps(target, ctx);
      moveBefore(parentNode, target, after);
      return target;
    }

Thanks

[brunoprietog]

Thanks @htcarr3!

[htcarr3]

@brunoprietog it looks like this is the only commit on main not already released. Thoughts on cutting a minor version release just for this?

[jorgemanrubia]

Hey @htcarr3 I need to fix a regression we detected in a recent Turbo version. I will cut a release with that in place. Aiming to do it this week.

[htcarr3]

@jorgemanrubia thank you!

[jorgemanrubia]

New versions of turbo and turbo-rails released containing this one!