Skip to content

fix(chat/effort): drive caret icon by dropdown state#2296

Open
LoneRifle wants to merge 1 commit into
huggingface:mainfrom
LoneRifle:fix/chat/icons
Open

fix(chat/effort): drive caret icon by dropdown state#2296
LoneRifle wants to merge 1 commit into
huggingface:mainfrom
LoneRifle:fix/chat/icons

Conversation

@LoneRifle

@LoneRifle LoneRifle commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Problem

The current chat window is reliant on CarbonCaretDown, which may not be the most suitable depending on context.

In particular:

  • the caret next to the model display name is slightly misleading, given that it opens the settings modal
  • the caret used in ThinkingEffortChip could change depending on whether the dropdown menu is open

Solution

Replace CarbonCaretDown with more suitable icons

  • use a gear icon next to the model display name so it is clearer that tapping would bring up the settings modal submitted separately as fix(chat): use lucide/settings-2 icon for settings #2300, using lucide/settings-2
  • listen to thinking effort dropdown menu state, and use that to determine whether caret down (closed) or caret up (open) should be displayed

Screenshots

Before

before

After

after
@gary149

gary149 commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

idk this feels a bit weird to me tbh
image

@LoneRifle

LoneRifle commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

idk this feels a bit weird to me tbh

I've reworked the PR so that it adds just the effort dropdown for now. Choice of icon for model id indicator resubmitted as #2300

@LoneRifle LoneRifle changed the title fix(chat): use more helpful icons Jun 9, 2026
@LoneRifle LoneRifle changed the title fix(chat/effort): drive carat icon by dropdown state Jun 9, 2026
@LoneRifle LoneRifle force-pushed the fix/chat/icons branch 5 times, most recently from 50dc089 to b063ded Compare June 12, 2026 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants