fix(chat/effort): drive caret icon by dropdown state#2296
Open
LoneRifle wants to merge 1 commit into
Open
Conversation
Collaborator
Contributor
Author
I've reworked the PR so that it adds just the effort dropdown for now. Choice of icon for model id indicator resubmitted as #2300 |
50dc089 to
b063ded
Compare
b063ded to
9149cee
Compare
9149cee to
b7dcf03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The current chat window is reliant on CarbonCaretDown, which may not be the most suitable depending on context.
In particular:
Solution
Replace CarbonCaretDown with more suitable icons
use a gear icon next to the model display name so it is clearer that tapping would bring up the settings modalsubmitted separately as fix(chat): uselucide/settings-2icon for settings #2300, usinglucide/settings-2Screenshots
Before
After