fix: mutable default argument in _visit_with_path#8130
Open
stef41 wants to merge 1 commit intohuggingface:mainfrom
Open
fix: mutable default argument in _visit_with_path#8130stef41 wants to merge 1 commit intohuggingface:mainfrom
_visit_with_path#8130stef41 wants to merge 1 commit intohuggingface:mainfrom
Conversation
Replace `visit_path: _VisitPath = []` with `Optional[_VisitPath] = None` to avoid the mutable default argument anti-pattern (B006). While the current callers always pass `visit_path + [k]` (creating new lists), the shared default list is a latent bug that would surface if any future code path uses `.append()` instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
visit_path: _VisitPath = []withOptional[_VisitPath] = Noneto avoid the mutable default argument anti-pattern (B006).While the current callers always use
visit_path + [k](creating new lists), the shared default list is a latent bug that would surface if any future code path mutatesvisit_pathin place (e.g. via.append()).The fix initializes
visit_path = []inside the function body whenNoneis passed.