-
Notifications
You must be signed in to change notification settings - Fork 2.4k
🐳 Docker update + Simplify Jobs doc #3931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| push: | ||
| branches: | ||
| - main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in theory, we need would need to build
- dev:
- every commit on main
- every new release of a dependency
- stable:
- every patch release
- every new release of a dependency
however, since we typically make a few commits per day on main, let's simplify things and just build both images when a new commit is made on main.
sergiopaniego
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the Training using Jobs guide, I can see that we'd need to update it adding:
- Details about the new trl Docker image with dependencies
- Details about TRL Jobs wrapper
Since it's just a small update, I can include it in this PR shortly. If you’d rather merge sooner, feel free, and I’ll open a new PR 😄
|
I took the opportunity to simplify the jobs documentation:
I'll merge this PR, as it's been opened for a while now, and I want the docker image to be operating. we can still refine in the future if needed |
|
|
||
| from .. import __version__ | ||
| from ..import_utils import ( | ||
| from trl import __version__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for scripts, we don't want relative imports
Our new simple docker image mostly intended to be used with trl jobs
Note that the image is already pushed to https://hub.docker.com/r/huggingface/trl-source-gpu (soon rename to just "huggingface/trl")