Skip to content

⏰ fix: add return to shift_tokens_right #3987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
qgallouedec merged 4 commits into from
Sep 3, 2025
Merged

⏰ fix: add return to shift_tokens_right #3987

qgallouedec merged 4 commits into from
Sep 3, 2025

Conversation

@ginkyenglee
Copy link
Contributor

@ginkyenglee ginkyenglee commented Sep 1, 2025

What does this PR do?

The function shift_tokens_right did not return its result, which made it unusable in practice.

  • Added return shifted_input_ids at the end of the function.
  • Ensures shift_tokens_right now correctly returns a torch.Tensor.
  • No breaking changes expected.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
qgallouedec
qgallouedec approved these changes Sep 3, 2025
View reviewed changes
Copy link
Member

@qgallouedec qgallouedec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks
@qgallouedec qgallouedec changed the title fix: add return to shift_tokens_right Sep 3, 2025
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 3, 2025

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.
@qgallouedec qgallouedec merged commit cb84da0 into huggingface:main Sep 3, 2025
10 checks passed
@ginkyenglee ginkyenglee deleted the fix/shift-tokens-right branch September 3, 2025 06:01
qgallouedec pushed a commit that referenced this pull request Sep 3, 2025
@ginkyenglee @qgallouedec
⏰ fix: add return to shift_tokens_right (#3987)
32cbb07
SamY724 pushed a commit to SamY724/trl that referenced this pull request Sep 6, 2025
@ginkyenglee
⏰ fix: add return to shift_tokens_right (huggingface#3987)
22a1756
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🩹 for patch

3 participants

@ginkyenglee @HuggingFaceDocBuilderDev @qgallouedec