-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add deprecation warnings to docstrings #4083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deprecation warnings to docstrings #4083
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Yes, I discovered this bug in doc-builder: the warning is not properly rendered when the parameter description is under a parameter subsection
What do you think? |
|
I opened an issue in doc-builder to report this bug: |
Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>
qgallouedec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
|
I mean, let's keep the malformed warning, not a big deal |


Add deprecation warnings to docstrings.
This PR adds deprecation notices to docstrings for documentation consistency: the docstring should match the actual behavior of the code.
This approach is better than removing it entirely because: