fix: collection filename default ignores explicit format, causing ent…#413
Open
RinatMadreiter wants to merge 1 commit into
Open
fix: collection filename default ignores explicit format, causing ent…#413RinatMadreiter wants to merge 1 commit into
RinatMadreiter wants to merge 1 commit into
Conversation
…ries to disappear
When a collection sets format: json (or yaml/toml) but doesn't set filename, normalizeContentEntry in lib/config.ts still defaults filename to "{year}-{month}-{day}-{primary}.md", so extension resolves to "md" regardless of the declared format. The collection listing endpoint then filters out every file that doesn't end in .md, returning an empty entry list with no error — entries silently vanish from the CMS UI even though the files exist in the repo. Reproduced with a format: json collection containing only .json files. Fix: derive the default filename's extension from format when it's explicitly set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ries to disappear
When a collection sets format: json (or yaml/toml) but doesn't set filename, normalizeContentEntry in lib/config.ts still defaults filename to "{year}-{month}-{day}-{primary}.md", so extension resolves to "md" regardless of the declared format. The collection listing endpoint then filters out every file that doesn't end in .md, returning an empty entry list with no error — entries silently vanish from the CMS UI even though the files exist in the repo. Reproduced with a format: json collection containing only .json files. Fix: derive the default filename's extension from format when it's explicitly set.