Add http2_max_local_error_reset_streams method to legacy client#277
Merged
seanmonstar merged 1 commit intoMay 1, 2026
Merged
Conversation
Contributor
Author
|
To share some context: we encountered this issue when cancelling internal client requests. Maybe there's something internally in hyper that can be fixed but see here for details for both h2 and tonic: |
op
force-pushed
the
op/legacy-client-max-local-error-reset-streams
branch
from
b63351e to
f4a85a4
Compare
Contributor
Author
|
Didn't realise that the |
Member
|
Oh right, this will need a release of hyper. I'll prioritize that. |
|
hi! I believe the field went out in hyper 1.9.0 -- is this now mergeable? |
Member
|
Yep, this just needs to bump the minimum version of the dependency |
…acy client Expose the h2 `max_local_error_reset_streams` setting on the legacy client builder, allowing users to configure the maximum number of local resets due to protocol errors. Requires hyper 1.9.0 for hyperium/hyper#4021
op
force-pushed
the
op/legacy-client-max-local-error-reset-streams
branch
from
f4a85a4 to
d1bfb5b
Compare
Contributor
Author
|
Great! Bumped dependency now. Let me know what you think 👍 |
seanmonstar
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose the h2
max_local_error_reset_streamssetting on the legacy client builder, allowing users to configure the maximum number of locally-reset streams before a GOAWAY frame is sent.