Skip to content

h2: "readd" max_pending_accept_reset_streams configuration option#3507

Merged
seanmonstar merged 1 commit into
hyperium:masterfrom
dsgallups:master
Dec 29, 2023
Merged

h2: "readd" max_pending_accept_reset_streams configuration option#3507
seanmonstar merged 1 commit into
hyperium:masterfrom
dsgallups:master

Conversation

@dsgallups

@dsgallups dsgallups commented Dec 28, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR is a partial reimplementation of @Noah-Kennedy's changes in #3201.

As described in #3461, hyper is missing the max_pending_accept_reset_streams added to h2 in #3201.

I essentially copy/pasted Noah's code, but not sure how to signal that he wrote the code in this PR. Not a git wizard, so if there's some way to remerge his changes from the original PR, I will close this.

Edit: Per the PR guidelines, happy to add tests for the existing configuration values to prevent this from re-occurring.
wouldn't have stopped this from happening 🤷, just lmk
@Noah-Kennedy

Noah-Kennedy commented Dec 28, 2023

Copy link
Copy Markdown
Contributor

I'm confused, is that change not in 1.0?
@dsgallups

dsgallups commented Dec 28, 2023

Copy link
Copy Markdown
Contributor Author

I don't think so...
@Noah-Kennedy

Noah-Kennedy commented Dec 28, 2023

Copy link
Copy Markdown
Contributor

@seanmonstar
feat(server|http2): add max_pending_accept_reset_streams back to `C…
7dc583e 
…onfig`

In places where required, the `max_pending_accept_reset_streams` option was reimplemented, as in PR #3201

May close #3461
@seanmonstar seanmonstar merged commit a9fa893 into hyperium:master Dec 29, 2023
allan2 added a commit to allan2/hyper-util that referenced this pull request Jan 3, 2024
@allan2
Add max_pending_accept_reset_streams
b33dbd2 
This function was in 0.14 but missed in 1.0.

The original function was merged [here](https://github.com/hyperium/hyper/pull/3201/files/e8296d1c5bded88a508f1ca1f35791c30803182d)
This commit simply copies directly from it.

The config part has been merged into hyper 1.0 (hyperium/hyper#3507).
This commit completes the re-addition of this missing function.
@allan2 allan2 mentioned this pull request Jan 3, 2024
Closed
@ikrivosheev ikrivosheev mentioned this pull request Jan 16, 2024
Merged
ikrivosheev pushed a commit to ikrivosheev/hyper-util that referenced this pull request Feb 27, 2024
@allan2 @ikrivosheev
Add max_pending_accept_reset_streams
cadb5f6 
This function was in 0.14 but missed in 1.0.

The original function was merged [here](https://github.com/hyperium/hyper/pull/3201/files/e8296d1c5bded88a508f1ca1f35791c30803182d)
This commit simply copies directly from it.

The config part has been merged into hyper 1.0 (hyperium/hyper#3507).
This commit completes the re-addition of this missing function.
seanmonstar pushed a commit to hyperium/hyper-util that referenced this pull request Feb 28, 2024
@allan2 @seanmonstar
Add max_pending_accept_reset_streams
1c49c39 
This function was in 0.14 but missed in 1.0.

The original function was merged [here](https://github.com/hyperium/hyper/pull/3201/files/e8296d1c5bded88a508f1ca1f35791c30803182d)
This commit simply copies directly from it.

The config part has been merged into hyper 1.0 (hyperium/hyper#3507).
This commit completes the re-addition of this missing function.
cratelyn added a commit to cratelyn/hyper that referenced this pull request Nov 27, 2024
@cratelyn
chore(server/conn): backport max_pending_accept_reset_streams() to …
28f5e67 
…builder

NB: this commit is based on the `0.14.x` release series.

the `server::conn::http2` submodule provides types that are
conditionally compiled when the `backports` feature is active, to
facilitate upgrading to the `1.x` release.

i've been working on upgrading the
[`linkerd2-proxy`](https://github.com/linkerd/linkerd2-proxy/) project
to use hyper 1.0, but encountered some gaps in `Builder<E>`'s interface
when setting the `backports` and `deprecated` features.

this adds a `max_pending_accept_reset_streams(..)` method
(_added in #3201_) to this builder, so that 0.14.x users relying on
this functionality can prepare to upgrade to hyper 1.x safely.

this is effectively a backport of hyperium#3507, which restored this interface
to the 1.0 release.

for more information, see:

* hyperium#3201
* hyperium#3507
* hyperium#3461
* https://hyper.rs/guides/1/upgrading/

Signed-off-by: katelyn martin <me+cratelyn@katelyn.world>
@cratelyn cratelyn mentioned this pull request Nov 27, 2024
Merged
cratelyn added a commit to cratelyn/hyper that referenced this pull request Nov 27, 2024
@cratelyn
chore(server/conn): backport max_pending_accept_reset_streams() to …
403b2d0 
…builder

NB: this commit is based on the `0.14.x` release series.

the `server::conn::http2` submodule provides types that are
conditionally compiled when the `backports` feature is active, to
facilitate upgrading to the `1.x` release.

i've been working on upgrading the
[`linkerd2-proxy`](https://github.com/linkerd/linkerd2-proxy/) project
to use hyper 1.0, but encountered some gaps in `Builder<E>`'s interface
when setting the `backports` and `deprecated` features.

this adds a `max_pending_accept_reset_streams(..)` method
(_added in #3201_) to this builder, so that 0.14.x users relying on
this functionality can prepare to upgrade to hyper 1.x safely.

this is effectively a backport of hyperium#3507, which restored this interface
to the 1.0 release.

for more information, see:

* hyperium#3201
* hyperium#3507
* hyperium#3461
* https://hyper.rs/guides/1/upgrading/

Signed-off-by: katelyn martin <me+cratelyn@katelyn.world>
seanmonstar pushed a commit that referenced this pull request Nov 29, 2024
@cratelyn
feat(server): backport max_pending_accept_reset_streams() to builder (
a24f0c0 
#3796)

the `server::conn::http2` submodule provides types that are
conditionally compiled when the `backports` feature is active, to
facilitate upgrading to the `1.x` release.

i've been working on upgrading the
[`linkerd2-proxy`](https://github.com/linkerd/linkerd2-proxy/) project
to use hyper 1.0, but encountered some gaps in `Builder<E>`'s interface
when setting the `backports` and `deprecated` features.

this adds a `max_pending_accept_reset_streams(..)` method
(_added in #3201_) to this builder, so that 0.14.x users relying on
this functionality can prepare to upgrade to hyper 1.x safely.

this is effectively a backport of #3507, which restored this interface
to the 1.0 release.

for more information, see:

* #3201
* #3507
* #3461
* https://hyper.rs/guides/1/upgrading/

Signed-off-by: katelyn martin <me+cratelyn@katelyn.world>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@dsgallups @Noah-Kennedy @seanmonstar