fix(server): max_local_error_reset_streams function mut self -> &mut self#3820
Merged
Conversation
finnbear
added a commit
to finnbear/hyper-util
that referenced
this pull request
Jan 1, 2025
Member
|
Well that's a major 🤯🤡 |
dswij
approved these changes
Jan 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an inconsistency with the HTTP/2 builder, which I assume was unintentional. This is a breaking change. Hopefully it counts as acceptable breakage.
I searched and only found one public, non-fork user of
max_local_error_reset_streamson GitHub (https://github.com/IGrok2/monorepo/blob/955a9b9bbed159b99637cf7576482af831acac7d/src/opnieuw/src/main.rs#L380-L388) and I think this PR wouldn't even break it.