[HnR-Autograder:1] Annotations endpoint - #10185
Draft
karenrasmussen wants to merge 10 commits into
Draft
Conversation
…kpoint and due date
Elimpizza
changed the title
karenrasmussen
commented
Aug 27, 2026
Comment on lines
+222
to
+233
| raise ValueError( # noqa: TRY003 | ||
| "USER_PHASE requires document_uri: phases are delimited by the" # noqa: EM101 | ||
| " checkpoint reveals of a (group, document) pair, so without a" | ||
| " document there is nothing to divide them by." | ||
| ) | ||
|
|
||
| if document_uri and (not assignment_ids or len(assignment_ids) != 1): | ||
| raise ValueError( # noqa: TRY003 | ||
| "document_uri requires assignment_ids to identify exactly one" # noqa: EM101 | ||
| " assignment: a checkpoint's reveal_date is only meaningful" | ||
| " for a single (group, document) pair, not a mix of" | ||
| " assignments." |
Contributor
Author
There was a problem hiding this comment.
h/views/api/bulk/stats.py doesn't catch this ValueError errores, and there's no exception view in h/views/api/errors.py that translates it into a 400. It ends up falling through to the generic json_error handler (context=Exception), which returns a generic 500 and reports it to the error tracker as an unexpected exception, instead of a clear 400 validation error.
This should raise a 400 or something similar.
Contributor
There was a problem hiding this comment.
You're right, Imoved both constraints into the JSON schema so they'd 400, but that only holds while the schema and the service agree. On it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.