Skip to content

Capitalise references to Mark for consistency #3031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2019
Merged

Capitalise references to Mark for consistency #3031

merged 1 commit into from
Oct 6, 2019

Conversation

@sauntimo
Copy link
Contributor

@sauntimo sauntimo commented Sep 25, 2019

Is this adding or improving a feature or fixing a bug?

  • feature: improving docs

What's the new behavior?

  • Capitalises references to "Mark" in the commands.md docs.
  • Currently both mark and Mark are used frequently and which could lead to confusion around whether they are the same thing - at least for me.
  • They all link to the same page and it appears they are referring to the same entity.
  • In mark.md the capitalised Mark is used so I thought it should be standardised on that.
  • Screenshot of current situation
    image
  • Screenshot with changes
    image

How does this change work?

  • Trivial docs update for clarity

Have you checked that...?

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn prettier.)
  • The relevant examples still work. (Run examples with yarn watch.)

Does this fix any issues or need any specific reviewers?

Fixes: n/a
Reviewers: Any
@ianstormtaylor
Copy link
Owner

ianstormtaylor commented Oct 6, 2019

Beautiful, thank you @sauntimo!
@ianstormtaylor ianstormtaylor merged commit 549359d into ianstormtaylor:master Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs

3 participants

@sauntimo @ianstormtaylor @cameracker