-
-
Notifications
You must be signed in to change notification settings - Fork 355
feat(shortcode): add buttons #830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for hugo-hextra ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Yeah, I definitely think this would be a great feature to add, I’ve been considering it for a while. For inspiration: Ideally, the button should be fairly generic, and the shortcode could expose options for things like variants, icons, etc. |
I already handled:
With your sentence, I could understand that you prefer: instead of If my understanding is correct, I will follow this way (it's easier to fix some problems with this approach) |
|
I used the same colors and button style (default, pills) as Flowbite. |
|
I need explicit confirmation about the design of the component. |
|
Seems right, I will do that 👍 |
It’s fine for now. In the future if it makes sense, we can move these color into a theme-wide palette CSS variables https://tailwindcss.com/docs/theme#using-a-custom-theme so reusing them will be much easier. |
|
But I changed the colors #830 (comment) Check the demo page https://deploy-preview-830--hugo-hextra.netlify.app/docs/guide/shortcodes/button/ |
|
I changed the design: options:
Check the demo page https://deploy-preview-830--hugo-hextra.netlify.app/docs/guide/shortcodes/button/ |
This looks amazing at first glance. Could you please clarify the default values for the I'm slightly confused about the |
By default, there is no border. |
|
I'll make some minor updates to the interface and styling to better align with the theme’s look and feel |
|
Remember, this is a draft; I was still waiting for feedback. |


This is a draft to discuss the idea.
I created a button shortcode/partial (based on the
hextra/buttonshortcode).One of the goals is to "remove"
hextra/buttonshortcode.I also created a test page with buttons for the demo.
I have several questions:
.Innercontent because it allows complete customization, but it's more complex than simple shortcode parameters.About the content, there are some complexities in aligning icons and text.
I added a CSS class to align the text and icons, but it requires the text to be wrapped in a
<span>tag.WDYT?
Demo: https://deploy-preview-830--hugo-hextra.netlify.app/docs/guide/shortcodes/button/