Add QBMAX expansions - #233
Conversation
|
This and #232 look just about identical. I think only one of them is needed? |
Just include |
|
|
||
|
|
||
| # {{{ Asymline taylor | ||
| class AsymLineTaylorLocalExpansion(LocalExpansionBase): |
There was a problem hiding this comment.
Add documentation describing what this does.
There was a problem hiding this comment.
Parts of this look like it interferes with/duplicates/undoes #229. Could you clarify the relationship? We should have one PR per change; it's not great to gobble multiple changes into one.
There was a problem hiding this comment.
You’re right — the changes in qbx.py overlap with those in #229. I’ve removed them from this PR to avoid duplication.
4a52f96 to
2764266
Compare
f8d13b4 to
4207c9b
Compare
4207c9b to
9ebc1af
Compare
9ebc1af to
9406a60
Compare
|
@inducer , I made some changes for the LineTaylorExpansion. Let me know if any changes are needed. Thank you! |
| if self._uses_expansion_vec and expansion_vec is None: | ||
| raise ValueError( | ||
| "expansion_vec is required when using " | ||
| "LineTaylorLocalExpansion") |
There was a problem hiding this comment.
Pytential tests failed due to the mandatory requirement of expansion_vec. One possible fix is:
if self._uses_expansion_vec and expansion_vec is None:
expansion_vec = targets - centersI wonder if it is okay.
914e587 to
eda2030
Compare
eda2030 to
a24d6fa
Compare
|
@inducer, this is ready for review now. The pytential API changes are in inducer/pytential#318. I wonder if any modifications are needed. |
2 participants
I also set CACHING_ENABLED = False in sumpy/tools.py. For different$\tau$ values, do we need to create separate cache files for the kernels?