This repository was archived by the owner on Jul 6, 2022. It is now read-only.
Support DELIMITER for MariaDB and MySQL#73
Open
gpetrounrt wants to merge 5 commits intoinferrinizzard:developfrom
Open
Support DELIMITER for MariaDB and MySQL#73gpetrounrt wants to merge 5 commits intoinferrinizzard:developfrom
gpetrounrt wants to merge 5 commits intoinferrinizzard:developfrom
Conversation
…ailing-point Implement support for parsing numbers with trailing floating-point
Owner
|
I've thought about how an implementation for dynamic token input would work and I don't have an efficient solution yet since the RegEx for each language is baked and compiled into one hard-coded string, ie. the delimiter for all languages is always ';'. Allowing users to dynamically regenerate this entire RegEx with custom delimiters/tokens would definitely be possible but will tank the processing time. May implement this as an experimental feature once I am back from hiatus / as a part of 5.2.x release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my initial attempt to address #72. I am not sure if this is the right approach to fix the issue. There are also a couple of pending issues, one with spaces before
ENDin MariaDB and the other with missing new line beforeBEGINin MySQL.