Skip to content

fix: properly account request timeouts not as shard write errors #26958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main-2.x
Choose a base branch
from
Open

fix: properly account request timeouts not as shard write errors #26958

wants to merge 1 commit into from
+16 −14

Conversation

@lowjoel
Copy link

@lowjoel lowjoel commented Nov 3, 2025

Closes #26957.

Clean up the use of our own timeouts and use Context timeouts (which are tied to a request). This simplifies the code, and also no longer counts HTTP request timeouts as errors.

  • I've read the contributing section of the project README.
  • Signed CLA (if not already signed).
@lowjoel
Copy link
Author

lowjoel commented Nov 3, 2025

Hmm, I've tried to keep behaviour unchanged apart from the metric count. Is the failure because of my change?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@lowjoel