Add system-level test coverage for OpenCode and PiAgent sources - #19
Open
winjer wants to merge 1 commit into
Open
Add system-level test coverage for OpenCode and PiAgent sources#19winjer wants to merge 1 commit into
winjer wants to merge 1 commit into
Conversation
Add tests/source_system_test.rs with 16 integration tests that feed OpenCode and PiAgent payloads via stdin to the real binary and assert on events delivered to the fake Langfuse — closing the largest gap in the test suite (every binary-level test previously exercised only the Claude Code Stop-hook path). Also fix a production gap in turns.rs: build_turns now extracts tool results from the message.tool_results field on assistant messages (where the OpenCode/PiAgent normalizers store them), so tool-span outputs are no longer silently None for these sources. The change is additive — Claude Code messages never carry this field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests/source_system_test.rs with 16 integration tests that feed OpenCode and PiAgent payloads via stdin to the real binary and assert on events delivered to the fake Langfuse — closing the largest gap in the test suite (every binary-level test previously exercised only the Claude Code Stop-hook path).
Also fix a production gap in turns.rs: build_turns now extracts tool results from the message.tool_results field on assistant messages (where the OpenCode/PiAgent normalizers store them), so tool-span outputs are no longer silently None for these sources. The change is additive — Claude Code messages never carry this field.