fix: build crash when renaming files #2235
Open
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… threshold This makes it so that the events are not fired until the file have stabilized. This also changes the order of the fired events. A move / rename now results in `delete` then `add` rather than the other way around. From `chokidar` README - https://github.com/paulmillr/chokidar?tab=readme-ov-file#performance: ``` awaitWriteFinish.stabilityThreshold (default: 2000). Amount of time in milliseconds for a file size to remain constant before emitting its event. ``` Fixes jackyzha0#2232
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
husjon
changed the title
awaitWriteFinish with 250ms threshold
|
@husjon got ahead of me! Found the same, but trying to workaround by retimeouting rebuildlate() with 250ms, keep youre fix. Cause it just config. And it work fine! Thx // on win11 it bug happened too (Quartz Version: v4.5.2) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that the events are not fired until the file have stabilized. This also changes the order of the fired events.
A move / rename now results in
deleteprior toaddrather than the other way around.Could also have set
atomictofalsebut that could potentially break when using other editors like VSCode or similar that uses atomic writes.From
chokidarREADME - https://github.com/paulmillr/chokidar?tab=readme-ov-file#performance:awaitWriteFinish.stabilityThreshold(default: 2000). Amount of time in milliseconds for a file size to remain constant before emitting its event.The threshold is intentionally set to a lower value of 250ms, so that we get a decent threshold while retaining snappiness between a save and a rebuild, although could be lowered / raised if needed.
Fixes #2232