fix: 修复邮件模板变量位于正文开头时无法替换的问题(indexOf 应包含位置0) - #9867
Open
RecursiveVar wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
EmailSendMsgHandle#replaceContent中使用content.indexOf(realNameExp) > 0判断变量是否存在,indexOf返回 0 表示占位符位于正文开头,该情况被漏掉,用户会收到内容仍为{REALNAME}/ 登录 token 占位符的原始邮件。修复
两处判断条件
> 0改为> -1(即包含位置 0)。位置:
jeecg-boot/jeecg-module-system/jeecg-system-biz/.../message/handle/impl/EmailSendMsgHandle.java