Skip to content

fix/remove-singleton-code-instance #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix/remove-singleton-code-instance #535

wants to merge 1 commit into from

Conversation

@hrvadl
Copy link

@hrvadl hrvadl commented Sep 30, 2025 •
edited
Loading

Description

I've removed singleton pattern usage to prevent concurrent writes when multiple maroto instances are created in parallel. Since code structure is an empty struct, then it's zero bytes in size and there's no point in having a singleton, as it does not optimize anything.

Related Issue
#534

Checklist

  • All methods associated with structs has func (<first letter of struct> *struct) method() {} name style.
  • Wrote unit tests for new/changed features.
  • Followed the unit test when,should naming pattern.
  • All mocks created with m := mocks.NewConstructor(t).
  • All mocks using m.EXPECT().MethodName() method to mock methods.
  • Updated docs/doc.go and docs/*
  • Updated example_test.go.
  • Updated README.md
  • New public methods/structs/interfaces has comments upside them explaining they responsibilities
  • Executed make dod with none issues pointed out by golangci-lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@hrvadl