Skip to content

Adding support for config omitEmpty which can be used instead of setting omitEmpty on individual fields #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adding support for config omitEmpty which can be used instead of setting omitEmpty on individual fields #445

wants to merge 1 commit into from

Conversation

k-anshul
Copy link

  • Update config.go

  • Update reflect_struct_encoder.go

Add a config omitEmpty which can be used instead of setting omitEmpty on individual fields
@k-anshul
adding omitEmpty config (#1)
4dfb1ab 
* Update config.go

* Update reflect_struct_encoder.go

Add a config omitEmpty which can be used instead of setting omitEmpty on individual fields
@codecov
Copy link

codecov bot commented Feb 19, 2020

Codecov Report

Merging #445 into master will increase coverage by 0.23%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #445      +/-   ##
=========================================
+ Coverage   86.27%   86.5%   +0.23%     
=========================================
  Files          41      41              
  Lines        5106    5107       +1     
=========================================
+ Hits         4405    4418      +13     
+ Misses        565     553      -12     
  Partials      136     136
Impacted Files Coverage Δ
config.go 89.41% <100%> (+0.05%) ⬆️
reflect_struct_encoder.go 89.07% <100%> (ø) ⬆️
reflect_struct_decoder.go 81.62% <0%> (+1.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7acbb40...4dfb1ab. Read the comment docs.
@k-anshul k-anshul requested a review from taowen February 20, 2020 05:55
@k-anshul
Copy link
Author

@AllenX2018 Can you please review and merge this request ?
@AllenX2018
Copy link
Collaborator

Please add test for the changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@k-anshul @AllenX2018