Add bool decoding to the fuzzy decoder extension #466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #466 +/- ##
==========================================
- Coverage 86.52% 86.25% -0.28%
==========================================
Files 41 41
Lines 5100 5100
==========================================
- Hits 4413 4399 -14
- Misses 546 560 +14
Partials 141 141
Continue to review full report at Codecov.
|
thfix13
force-pushed
the
add-fuzzy-bool-decoding
branch
from
fec0ed6 to
32c48e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the table here, "fuzzy mode" should be able to support decoding multiple JSON types into a Go bool. However, that's not currently the case.
This PR adds a fuzzy bool decoder to the fuzzy decoder extension, with behaviour in line with the table (modulo arrays and objects, which don't seem to be handled for other Go types at the moment, either — the code to handle these is included anyway, commented out for consistency with other types).